fix(ng-dev/release): delete node_modules before pnpm install #3203
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We delete the node_modules prior to a pnpm install during the release because if a package exists on main, but does not exist on the released branch, the node_modules directory will persist and bazel will attempt to pick it up and install it but no package.json exists for it.
josephperrott
requested review from
thePunderWoman
and removed request for
alan-agius4
tjshiu
approved these changes
Oct 30, 2025
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We delete the node_modules prior to a pnpm install during the release because if a package exists on main, but does not exist on the released branch, the node_modules directory will persist and bazel will attempt to pick it up and install it but no package.json exists for it.